From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change
Date: Fri, 21 Nov 2008 17:45:16 +0000 [thread overview]
Message-ID: <4926F3AC.4000201@eu.citrix.com> (raw)
In-Reply-To: <200811211736.23473.paul@codesourcery.com>
Paul Brook wrote:
> On Friday 21 November 2008, Stefano Stabellini wrote:
>> + Â Â Â Â surface->data = (uint8_t*) qemu_reallocz(surface->data,
>> surface->linesize * surface->height);
>> + Â Â else
>> + Â Â Â Â surface->data = (uint8_t*) qemu_mallocz(surface->linesize *
>> surface->height);
>
> Do these really need to be zeroed?
>
> reallocz seems like a bit of a funny concept. I doubt it's more efficient than
> free/mallocz. The point of normal realloc is that is preserves the contents
> of the block, even if it moves.
>
Actually I think they don't need to be, I have been probably overzelous.
I'll do some tests to be sure, then I'll drop it.
next prev parent reply other threads:[~2008-11-21 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 17:08 [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change Stefano Stabellini
[not found] ` <200811211736.23473.paul@codesourcery.com>
2008-11-21 17:45 ` Stefano Stabellini [this message]
2008-11-22 20:00 ` Anthony Liguori
2008-11-24 16:51 ` Stefano Stabellini
2008-11-24 19:58 ` Anthony Liguori
2008-11-25 12:23 ` Stefano Stabellini
2008-11-25 12:38 ` Stefano Stabellini
2008-11-25 14:35 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4926F3AC.4000201@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.