From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Mohammad Iqbal Ahmad <mahmad@marvell.com>,
dev@dpdk.org, Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>,
Conor Walsh <conor.walsh@intel.com>,
jerinj@marvell.com, skori@marvell.com, skoteshwar@marvell.com,
pbhagavatula@marvell.com, kirankumark@marvell.com,
psatheesh@marvell.com, asekhar@marvell.com, anoobj@marvell.com,
gakhil@marvell.com, hkalra@marvell.com, ndabilpuram@marvell.com
Subject: Re: [PATCH v1] examples/l3fwd: fix for coverity scan
Date: Wed, 12 Jul 2023 16:39:30 +0200 [thread overview]
Message-ID: <4927488.mogB4TqSGs@thomas> (raw)
In-Reply-To: <20230706110926.689d1344@hermes.local>
06/07/2023 20:09, Stephen Hemminger:
> On Wed, 01 Feb 2023 18:28:44 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 10/01/2023 15:56, Mohammad Iqbal Ahmad:
> > > This patch fixes (Logically dead code) coverity issue.
> > > This patch also fixes (Uninitialized scalar variable) coverity issue.
> > >
> > > Coverity issue: 381687
> > > Coverity issue: 381686
> > > Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method")
> > >
> > > Signed-off-by: Mohammad Iqbal Ahmad <mahmad@marvell.com>
> >
> > It seems you removed "if (nh != FIB_DEFAULT_HOP)"
> >
> > Please could you explain what was the issue
> > inside the commit message.
> > It could help to find a better title as well.
>
> Coverity is spotting that the same condition is evaluated first
> in the if() then in the conditional expression. So yes it is a bug.
>
> Would prefer the title of
> examples/l3fwd: fix duplicate expression for default nexthop
>
> Don't think the default nexthop was ever tested. If it was then
> hops[i] would have never been updated. Probably would just get previous
> value so it worked.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
prev parent reply other threads:[~2023-07-12 14:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 7:39 [PATCH v1 1/2] mailmap: add contributor to list Mohammad Iqbal Ahmad
2022-12-16 7:39 ` [PATCH v1 2/2] app/test-flow-perf: fix division or module by zero Mohammad Iqbal Ahmad
2022-12-19 8:34 ` [PATCH v2 1/2] mailmap: add contributor to list Mohammad Iqbal Ahmad
2022-12-19 8:34 ` [PATCH v2 2/2] app/test-flow-perf: fix division or module by zero Mohammad Iqbal Ahmad
2023-01-23 11:41 ` [PATCH v2 1/2] mailmap: add contributor to list Mohammad Iqbal Ahmad
2023-01-23 15:32 ` Thomas Monjalon
2023-01-24 10:38 ` [PATCH v3 1/1] app/test-flow-perf: fix division or module by zero Mohammad Iqbal Ahmad
2023-02-20 12:46 ` Wisam Monther
2023-02-20 12:51 ` Thomas Monjalon
2023-03-06 10:21 ` Wisam Monther
2023-03-12 14:05 ` Thomas Monjalon
2023-01-09 10:57 ` [PATCH v1 1/2] mailmap: add contributor to list Mohammad Iqbal Ahmad
2023-01-10 14:56 ` [PATCH v1] examples/l3fwd: fix for coverity scan Mohammad Iqbal Ahmad
2023-01-18 11:24 ` Walsh, Conor
2023-02-01 17:28 ` Thomas Monjalon
2023-07-06 18:09 ` Stephen Hemminger
2023-07-12 14:39 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4927488.mogB4TqSGs@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=asekhar@marvell.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.ananyev@huawei.com \
--cc=mahmad@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=psatheesh@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=stephen@networkplumber.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.