All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 05/11] KVM: Add fields for MSI device assignment
Date: Sun, 23 Nov 2008 12:10:47 +0200	[thread overview]
Message-ID: <49292C27.7030206@redhat.com> (raw)
In-Reply-To: <1227095114-13792-6-git-send-email-sheng@linux.intel.com>

Sheng Yang wrote:
> Prepared for kvm_arch_assigned_device_msi_dispatch().
>
> @@ -507,10 +507,17 @@ struct kvm_assigned_irq {
>  	__u32 guest_irq;
>  	__u32 flags;
>  	union {
> +		struct {
> +			__u32 addr_lo;
> +			__u32 addr_hi;
>   

__u64 addr;

?

> +			__u32 data;
>   


> @@ -307,8 +308,11 @@ struct kvm_assigned_dev_kernel {
>  	int host_devfn;
>  	int host_irq;
>  	int guest_irq;
> +	struct msi_msg guest_msi;
>  #define KVM_ASSIGNED_DEV_GUEST_INTX	(1 << 0)
> +#define KVM_ASSIGNED_DEV_GUEST_MSI	(1 << 1)
>  #define KVM_ASSIGNED_DEV_HOST_INTX	(1 << 8)
> +#define KVM_ASSIGNED_DEV_HOST_MSI	(1 << 9)
>   

Okay, I see the reason for non sequential assignment.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-11-23 10:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 11:45 [PATCH 0/11][v5] Enable MSI for KVM Sheng Yang
2008-11-19 11:45 ` [PATCH 01/11] KVM: Move ack notifier register and IRQ sourcd ID request Sheng Yang
2008-11-23 10:06   ` Avi Kivity
2008-11-19 11:45 ` [PATCH 02/11] KVM: Separate update irq to a single function Sheng Yang
2008-11-23 10:06   ` Avi Kivity
2008-11-19 11:45 ` [PATCH 03/11] KVM: Replace irq_requested with more generic irq_requested_type Sheng Yang
2008-11-23 10:07   ` Avi Kivity
2008-11-19 11:45 ` [PATCH 04/11] KVM: Clean up assigned_device_update_irq Sheng Yang
2008-11-19 11:45 ` [PATCH 05/11] KVM: Add fields for MSI device assignment Sheng Yang
2008-11-23 10:10   ` Avi Kivity [this message]
2008-11-24  1:51     ` Sheng Yang
2008-11-25 14:46       ` Avi Kivity
2008-11-25 14:49         ` Avi Kivity
2008-11-25 15:07           ` Sheng Yang
2008-11-19 11:45 ` [PATCH 06/11] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
2008-11-19 11:45 ` [PATCH 07/11] x86: Rename MSI macro name Sheng Yang
2008-11-23 10:12   ` Avi Kivity
2008-11-24  2:02     ` Sheng Yang
2008-11-19 11:45 ` [PATCH 08/11] x86: Add MSI delivery mode value Sheng Yang
2008-11-19 11:45 ` [PATCH 09/11] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-11-23 10:22   ` Avi Kivity
2008-11-24  2:02     ` Sheng Yang
2008-11-19 11:45 ` [PATCH 10/11] KVM: Enable MSI for device assignment Sheng Yang
2008-11-23 10:25   ` Avi Kivity
2008-11-19 11:45 ` [PATCH 11/11] KVM: MSI to INTx translate Sheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49292C27.7030206@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.