From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 3/4] Support for device capability
Date: Sun, 23 Nov 2008 14:28:21 +0200
Message-ID: <49294C65.7070404@redhat.com>
References: <1227258267-22901-1-git-send-email-sheng@linux.intel.com> <1227258267-22901-4-git-send-email-sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>, kvm@vger.kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:39141 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750890AbYKWM21 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 23 Nov 2008 07:28:27 -0500
In-Reply-To: <1227258267-22901-4-git-send-email-sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Sheng Yang wrote:
> This framework can be easily extended to support device capability, like
> MSI/MSI-x.
>
>   

At least some of this should go into pci.c, so non-assigned devices can 
benefit.

>  static void assigned_dev_pci_write_config(PCIDevice *d, uint32_t address,
>                                            uint32_t val, int len)
>  {
>      int fd;
>      ssize_t ret;
> +    AssignedDevice *pci_dev = (AssignedDevice *)d;
>   

container_of()


-- 
error compiling committee.c: too many arguments to function