From: Robert Hancock <hancockr@shaw.ca>
To: linux-ide@vger.kernel.org
Cc: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] ata: Remove inline attribute from ata_sff_host_intr()
Date: Sun, 23 Nov 2008 23:42:10 -0600 [thread overview]
Message-ID: <492A3EB2.8070504@shaw.ca> (raw)
In-Reply-To: <492A39A7.4080703@kernel.org>
Tejun Heo wrote:
> David Daney wrote:
>> ata: Remove inline attribute from ata_sff_host_intr()
>>
>> ata_sff_host_intr is a public function, it should not be declared inline.
>
> Why not?
>
Well, it's a bit unusual to have a non-static inline (an exported symbol
no less) in a C file.. how could any callers outside the file ever
actually inline it? Aside from that it seems a bit big for inlining..
next prev parent reply other threads:[~2008-11-24 5:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 0:39 [PATCH] ata: Remove inline attribute from ata_sff_host_intr() David Daney
2008-11-24 5:20 ` Tejun Heo
2008-11-24 5:42 ` Robert Hancock [this message]
2008-11-24 5:49 ` Tejun Heo
2008-11-24 17:21 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492A3EB2.8070504@shaw.ca \
--to=hancockr@shaw.ca \
--cc=ddaney@caviumnetworks.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.