Re: [Qemu-devel] [PATCH 1/5] Remove tabs from qcow_aio_read_cb(). Fix indentation.

[Anthony Liguori <anthony@codemonkey.ws>]

Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
>  block-qcow2.c |   78 +++++++++++++++++++++++++++++----------------------------
>  1 files changed, 39 insertions(+), 39 deletions(-)
>
> diff --git a/block-qcow2.c b/block-qcow2.c
> index dc73769..ab19a4e 100644
> --- a/block-qcow2.c
> +++ b/block-qcow2.c
> @@ -1186,7 +1186,7 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>  
>      acb->hd_aiocb = NULL;
>      if (ret < 0) {
> -    fail:
> +fail:
>          acb->common.cb(acb->common.opaque, ret);
>          qemu_aio_release(acb);
>          return;
> @@ -1200,8 +1200,8 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>      } else {
>          if (s->crypt_method) {
>              encrypt_sectors(s, acb->sector_num, acb->buf, acb->buf,
> -                            acb->n, 0,
> -                            &s->aes_decrypt_key);
> +                    acb->n, 0,
> +                    &s->aes_decrypt_key);
>   

Why did you change this indenting?  There is no tabs and I think it's 
better the way it is than how you made it.

> @@ -1551,7 +1551,7 @@ static int qcow_make_empty(BlockDriverState *bs)
>  
>      memset(s->l1_table, 0, l1_length);
>      if (bdrv_pwrite(s->hd, s->l1_table_offset, s->l1_table, l1_length) < 0)
> -	return -1;
> +    return -1;
>      ret = bdrv_truncate(s->hd, s->l1_table_offset + l1_length);
>      if (ret < 0)
>          return ret;
>   

That's really not right.

Regards,

Anthony Liguori

>
>