From: "H. Peter Anvin" <hpa@zytor.com>
To: Alexander van Heukelum <heukelum@mailshack.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Sam Ravnborg <sam@ravnborg.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration
Date: Mon, 24 Nov 2008 10:04:50 -0800 [thread overview]
Message-ID: <492AECC2.50202@zytor.com> (raw)
In-Reply-To: <20081124091031.GA8187@mailshack.com>
Alexander van Heukelum wrote:
>
> The problem is that ENTRY(interrupt) is done in init.rodata, and
> ENTRY(irq_entries_start) is done in .text. So inside the .S-file,
> they are nested, but in the .o-file they are separate. Instead of
> removing ENTRY(irq_entries_start), I think we should just expand to:
>
> .section .init.rodata,"a"
> .p2align 5
> .global interrupt
> interrupt:
>
> and
>
> size interrupt, .-interrupt
>
> But the only importance I can think of is that this keeps both
> the "interrupt" array and irq_entries_start visible in debugging
> information.
>
> Alternatively, we could probably do away with the interrupt
> array entirely. We _know_ how the irq stubs are structured and
> irq_entries_start is in principle enough information to reconstruct
> all information in interrupt.
>
I'd rather not get rid of the interrupt array. But more fundamentally,
interrupt is a data symbol, not an entry point.
-hpa
next prev parent reply other threads:[~2008-11-24 18:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 16:57 [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration Cyrill Gorcunov
2008-11-23 17:00 ` Cyrill Gorcunov
2008-11-23 17:51 ` Sam Ravnborg
2008-11-23 17:58 ` Cyrill Gorcunov
2008-11-23 18:10 ` Cyrill Gorcunov
2008-11-23 18:12 ` Sam Ravnborg
2008-11-23 18:21 ` Cyrill Gorcunov
2008-11-23 18:43 ` Cyrill Gorcunov
2008-11-23 18:46 ` Alexander van Heukelum
2008-11-23 18:54 ` Ingo Molnar
2008-11-23 18:57 ` Cyrill Gorcunov
2008-11-23 19:00 ` Ingo Molnar
2008-11-23 19:04 ` Cyrill Gorcunov
2008-11-23 19:22 ` Cyrill Gorcunov
2008-11-23 19:31 ` Ingo Molnar
2008-11-23 19:48 ` Cyrill Gorcunov
2008-11-23 22:35 ` Ingo Molnar
2008-11-24 9:10 ` Alexander van Heukelum
2008-11-24 18:04 ` H. Peter Anvin [this message]
2008-11-23 19:51 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492AECC2.50202@zytor.com \
--to=hpa@zytor.com \
--cc=gorcunov@gmail.com \
--cc=heukelum@mailshack.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.