From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4iCF-0005gK-J2 for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:38:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4iCE-0005g5-WC for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:38:15 -0500 Received: from [199.232.76.173] (port=41331 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4iCE-0005g2-NX for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:38:14 -0500 Received: from yw-out-1718.google.com ([74.125.46.154]:45863) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L4iCE-0005DH-86 for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:38:14 -0500 Received: by yw-out-1718.google.com with SMTP id 6so863783ywa.82 for ; Mon, 24 Nov 2008 12:38:13 -0800 (PST) Message-ID: <492B10B1.1050409@codemonkey.ws> Date: Mon, 24 Nov 2008 14:38:09 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [5780] Native BSD host USB support (Juergen Lock, Lonnie Mendez) References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl wrote: > Revision: 5780 > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5780 > Author: blueswir1 > Date: 2008-11-22 21:03:55 +0000 (Sat, 22 Nov 2008) > > Log Message: > ----------- > Native BSD host USB support (Juergen Lock, Lonnie Mendez) > This broke the Windows build and cross compiling. Was this patch posted to the list or did you pull it from the URL that Juergen's been posting? I would have given the patch a run if it had been posted first and we could have avoided the breakage. > Modified: trunk/configure > =================================================================== > --- trunk/configure 2008-11-22 20:49:12 UTC (rev 5779) > +++ trunk/configure 2008-11-22 21:03:55 UTC (rev 5780) > @@ -221,6 +221,7 @@ > audio_possible_drivers="oss alsa sdl esd pa" > linux="yes" > linux_user="yes" > +usb="linux" > if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then > kqemu="yes" > audio_possible_drivers="$audio_possible_drivers fmod" > @@ -231,6 +232,7 @@ > if [ "$bsd" = "yes" ] ; then > if [ "$darwin" != "yes" ] ; then > make="gmake" > + usb="bsd" > fi > bsd_user="yes" > fi > This whole set of checks is horribly broken because it relies on uname -s. Such a thing doesn't exist on Windows but more importantly, when cross compiling, uname is meaningless. What we really should do, is compile a small test program that checks for: #ifndef __linux__ #error Not linux #endif And then try compiling that to see if we're on Linux or not. The same with FreeBSD et al. > Added: trunk/usb-stub.c > This stub doesn't build at all. The copyright is a little bogus too because I don't think Fabrice, Max, or TJ have ever contributed to this file. > =================================================================== > --- trunk/usb-stub.c (rev 0) > +++ trunk/usb-stub.c 2008-11-22 21:03:55 UTC (rev 5780) > @@ -0,0 +1,49 @@ > +/* > + * Stub host USB redirector > + * > + * Copyright (c) 2005 Fabrice Bellard > + * > + * Copyright (c) 2008 Max Krasnyansky > + * Support for host device auto connect & disconnect > + * Major rewrite to support fully async operation > + * > + * Copyright 2008 TJ > + * Added flexible support for /dev/bus/usb /sys/bus/usb/devices in addition > + * to the legacy /proc/bus/usb USB device discovery and handling > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to deal > + * in the Software without restriction, including without limitation the rights > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > + * copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN > + * THE SOFTWARE. > + */ > + > +#include "hw/usb.h" > This is not enough includes to produce something buildable. > + > +void usb_host_info(void) > +{ > + term_printf("USB host devices not supported\n"); > +} > + > +/* XXX: modify configure to compile the right host driver */ > +USBDevice *usb_host_device_open(const char *devname) > +{ > + return NULL; > +} > + > +int usb_host_device_close(const char *devname) > +{ > + return 0; > +} > > Regards, Anthony Liguori > >