All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: kvm-devel <kvm@vger.kernel.org>
Cc: Avi Kivity <avi@redhat.com>
Subject: [PATCH] Fix -no-kvm with SMP
Date: Tue, 25 Nov 2008 13:45:20 +0100	[thread overview]
Message-ID: <492BF360.6040709@siemens.com> (raw)

Fix condition for the !kvm_enabled() case.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

 qemu/hw/apic.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/qemu/hw/apic.c b/qemu/hw/apic.c
index 8836784..6657276 100644
--- a/qemu/hw/apic.c
+++ b/qemu/hw/apic.c
@@ -436,7 +436,8 @@ static void apic_init_ipi(APICState *s)
 
     cpu_reset(s->cpu_env);
 
-    if (!(s->apicbase & MSR_IA32_APICBASE_BSP) && !qemu_kvm_irqchip_in_kernel())
+    if (!(s->apicbase & MSR_IA32_APICBASE_BSP) &&
+        (!kvm_enabled() || !qemu_kvm_irqchip_in_kernel()))
         s->cpu_env->halted = 1;
 
     if (kvm_enabled() && !qemu_kvm_irqchip_in_kernel())

             reply	other threads:[~2008-11-25 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 12:45 Jan Kiszka [this message]
2008-11-25 14:30 ` [PATCH] Fix -no-kvm with SMP Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=492BF360.6040709@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.