From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gianluca Guida <gianluca.guida@eu.citrix.com>
Subject: Re: Re: issues with movnti emulation
Date: Tue, 25 Nov 2008 14:01:28 +0000
Message-ID: <492C0538.9030702@eu.citrix.com>
References: <C54B4B1D.1F707%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C54B4B1D.1F707%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
> I think the issue is that I did a bad backport to 3.3. The 'case 0xc3'
> should be under twobyte_special_insn rather than twobyte_insn, right? The
> two separate paths got merged into one in xen-unstable.

This seems actually to be the case. The actual move from src.val to 
dst.val never happened with the current patch, and this made movnti to 
write in memory the original dst.val value, leading to memory corruption.

By moving the switch case into twobyte_insn the problem goes away.

Gianluca