From: Jeff Garzik <jeff@garzik.org>
To: Qinghuang Feng <qhfeng.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc
Date: Tue, 25 Nov 2008 11:39:11 -0500 [thread overview]
Message-ID: <492C2A2F.9070309@garzik.org> (raw)
In-Reply-To: <491feb5b.08486e0a.075a.4c48@mx.google.com>
Qinghuang Feng wrote:
> No argument named @isich in radisys_set_dmamode,
> remove it.
>
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
> ---
> diff --git a/drivers/ata/pata_radisys.c b/drivers/ata/pata_radisys.c
> index 0b0aa45..695d44a 100644
> --- a/drivers/ata/pata_radisys.c
> +++ b/drivers/ata/pata_radisys.c
> @@ -81,7 +81,6 @@ static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev)
> * radisys_set_dmamode - Initialize host controller PATA DMA timings
> * @ap: Port whose timings we are configuring
> * @adev: Device to program
> - * @isich: True if the device is an ICH and has IOCFG registers
> *
> * Set MWDMA mode for device, in host controller PCI config space.
> *
applied 1-7 to #upstream, after combining into a single patch. I felt a
single changeset was more appropriate.
next prev parent reply other threads:[~2008-11-25 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 9:43 [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc Qinghuang Feng
2008-11-17 17:43 ` Randy Dunlap
2008-11-25 16:39 ` Jeff Garzik [this message]
2008-11-25 17:00 ` sniper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492C2A2F.9070309@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qhfeng.kernel@gmail.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.