All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	p_gortmaker@yahoo.com, netdev@vger.kernel.org, mel@csn.ul.ie,
	shemminger@linux-foundation.org
Subject: Re: [BUILD_FAILURE] linux-next: 20081125 - 8390 network driver build fails
Date: Tue, 25 Nov 2008 12:08:50 -0800	[thread overview]
Message-ID: <492C5B52.6090803@oracle.com> (raw)
In-Reply-To: <20081125195756.12317499@lxorguk.ukuu.org.uk>

Alan Cox wrote:
>> drivers/net/8390p.o: In function `ei_get_stats':
>> (.text+0x1050): multiple definition of `ei_get_stats'
>> drivers/net/8390.o:(.text+0xe20): first defined here
>> drivers/net/8390p.o: In function `ei_start_xmit':
>> (.text+0x1100): multiple definition of `ei_start_xmit'
>> drivers/net/8390.o:(.text+0xef0): first defined here
>> drivers/net/8390p.o: In function `ei_tx_timeout':
>> (.text+0xec0): multiple definition of `ei_tx_timeout'
>> drivers/net/8390.o:(.text+0xce0): first defined here
>> drivers/net/8390p.o: In function `ei_set_multicast_list':
>> (.text+0x1000): multiple definition of `ei_set_multicast_list'
>> drivers/net/8390.o:(.text+0xea0): first defined here
>> make[2]: *** [drivers/net/built-in.o] Error 1
>>
>> and none of these functions is static in lib8390.c.
> 
> They seem to be just fine in the base tree, so somebody has merged
> something stoopid.
> 
> 
>  */
> 
> static int ei_start_xmit(struct sk_buff *skb, struct net_device *dev)  
> {

OK, ack that, thanks.

Looks like it's due to CONFIG_COMPAT_NET_DEV_OPS.

Dave, no need to drop my hp-plus driver patch.

~Randy


  reply	other threads:[~2008-11-25 20:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 10:37 linux-next: Tree for November 25 Stephen Rothwell
2008-11-25 18:25 ` [BUILD_FAILURE] linux-next: 20081125 - 8390 network driver build fails Kamalesh Babulal
2008-11-25 18:39   ` Randy Dunlap
2008-11-25 18:51     ` Alan Cox
2008-11-25 19:34       ` Randy Dunlap
2008-11-25 19:38         ` Alan Cox
2008-11-25 19:38           ` Alan Cox
2008-11-25 19:46           ` Randy Dunlap
2008-11-25 19:57             ` Alan Cox
2008-11-25 19:57               ` Alan Cox
2008-11-25 20:08               ` Randy Dunlap [this message]
2008-11-25 21:42                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=492C5B52.6090803@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=netdev@vger.kernel.org \
    --cc=p_gortmaker@yahoo.com \
    --cc=sfr@canb.auug.org.au \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.