From: Coly Li <coyli@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix similar typos to successfull, v2
Date: Wed, 26 Nov 2008 16:48:14 +0800 [thread overview]
Message-ID: <492D0D4E.1040609@suse.de> (raw)
In-Reply-To: <20081125145308.8633bf4a.akpm@linux-foundation.org>
Andrew Morton Wrote:
> On Tue, 25 Nov 2008 01:44:13 +0800
> Coly Li <coyli@suse.de> wrote:
>
>> When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull "
>> in kernel tree, 22 typos found totally -- great minds always think alike :)
>
> Mutter. I have a super-strict (lol) policy of "I don't take patches
> which fix typos/spellos in comments", because we have so many such
> errors, and I'd get buried in silly patches. But I do take patches
> which fix documentation and user-visible printks, etc.
>
The first time I know this policy, remember it now ;)
>> Documentation/hwmon/abituguru-datasheet | 4 ++--
>> Documentation/scsi/scsi_fc_transport.txt | 4 ++--
>> arch/powerpc/platforms/cell/spufs/spufs.h | 2 +-
>> drivers/infiniband/hw/nes/nes_cm.c | 2 +-
>> drivers/isdn/hardware/eicon/debuglib.h | 2 +-
>> drivers/isdn/hardware/eicon/os_4bri.c | 2 +-
>> drivers/isdn/hardware/eicon/os_bri.c | 2 +-
>> drivers/isdn/hardware/eicon/os_pri.c | 2 +-
>> drivers/mtd/ubi/kapi.c | 2 +-
>> drivers/net/wireless/ath5k/dma.c | 2 +-
>> drivers/net/wireless/zd1211rw/zd_mac.c | 2 +-
>> drivers/s390/block/dasd_3990_erp.c | 2 +-
>> drivers/s390/block/dasd_int.h | 2 +-
>> drivers/s390/char/tape_3590.c | 2 +-
>> drivers/s390/cio/cio.c | 2 +-
>> drivers/s390/cio/qdio_main.c | 2 +-
>> fs/ext4/extents.c | 2 +-
>> fs/ocfs2/dlmglue.c | 4 ++--
>> net/sctp/auth.c | 2 +-
>
> This patch sneakily mixed the two up, so I merged it ;)
grep does not understand difference between code and comments ;)
I am not 100% agreed that leaving typos/spellos in comments is a proper policy. Anyway, thanks for
the effort to merge this patch, it's impossible for me to put so many maintainers into Cc list :)
--
Coly Li
SuSE PRC Labs
prev parent reply other threads:[~2008-11-26 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 17:44 [PATCH] fix similar typos to successfull, v2 Coly Li
2008-11-24 17:40 ` Randy Dunlap
2008-11-25 22:53 ` Andrew Morton
2008-11-25 23:49 ` Fernando Carrijo
2008-11-26 0:05 ` Andrew Morton
2008-11-26 0:42 ` Fernando Carrijo
2008-11-26 8:48 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492D0D4E.1040609@suse.de \
--to=coyli@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.