From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add KVM version to monitor "info version" Date: Wed, 26 Nov 2008 13:23:44 +0200 Message-ID: <492D31C0.9070101@redhat.com> References: <87abbmn5x0.fsf@obelix.mork.no> <20081126105525.GF16540@redhat.com> <5d6222a80811260318i38e1a8c9n40d8336734347371@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Daniel P. Berrange" , =?ISO-8859-1?Q?Bj=F8rn_?= =?ISO-8859-1?Q?Mork?= , kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49242 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbYKZLX6 (ORCPT ); Wed, 26 Nov 2008 06:23:58 -0500 In-Reply-To: <5d6222a80811260318i38e1a8c9n40d8336734347371@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > On Wed, Nov 26, 2008 at 8:55 AM, Daniel P. Berrange wrote: > >> On Wed, Nov 26, 2008 at 11:22:03AM +0100, Bj?rn Mork wrote: >> >>> Trying to track the current KVM head as closely as possible, I often >>> find myself wondering which KVM version a particular guest instance is >>> running. The attached patch adds this information to the monitor >>> command "info version": >>> >>> (qemu) info version >>> 0.9.1 (kvm-79) >>> >> I'd really rather we didn't touch the 'info version' command since it >> means we have different syntax from upstream QEMU. If we want KVM >> version info exposed, then I'd suggest 'info kvmversion' or some other >> new command. >> > > I believe it fits nicely into info kvm. Instead of enabled/disabled, > we could answer > disabled or kvm-whatever > > (qemu) info kvm enabled (kvm-123) or (qemu) info kvm enabled version kvm-123 May be easier to parse, and more backwards compatible. -- error compiling committee.c: too many arguments to function