From: roel kluin <roel.kluin@gmail.com>
To: hverkuil@xs4all.nl, mchehab@infradead.org
Cc: linux-kernel@vger.kernel.org, video4linux-list@redhat.com
Subject: [PATCH] V4L/DVB (7725): cx23885: unsigned cx23417_mailbox cannot be negative
Date: Wed, 26 Nov 2008 17:03:18 -0500 [thread overview]
Message-ID: <492DC7A6.5090806@gmail.com> (raw)
Unsigned cx23417_mailbox cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
dev->cx23417_mailbox has type u32, see
vi drivers/media/video/cx23885/cx23885.h +330
cx23885_find_mailbox() returns int, see
vi drivers/media/video/cx23885/cx23885-417.c +832
diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
index 8118091..f0f09aa 100644
--- a/drivers/media/video/cx23885/cx23885-417.c
+++ b/drivers/media/video/cx23885/cx23885-417.c
@@ -1028,12 +1028,13 @@ static int cx23885_initialize_codec(struct cx23885_dev *dev)
printk(KERN_ERR "%s() f/w load failed\n", __func__);
return retval;
}
- dev->cx23417_mailbox = cx23885_find_mailbox(dev);
- if (dev->cx23417_mailbox < 0) {
+ retval = cx23885_find_mailbox(dev);
+ if (retval < 0) {
printk(KERN_ERR "%s() mailbox < 0, error\n",
__func__);
return -1;
}
+ dev->cx23417_mailbox = retval;
retval = cx23885_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0);
if (retval < 0) {
printk(KERN_ERR
next reply other threads:[~2008-11-26 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 22:03 roel kluin [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-10 15:58 [PATCH] V4L/DVB (7725): cx23885: unsigned cx23417_mailbox cannot be negative roel kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492DC7A6.5090806@gmail.com \
--to=roel.kluin@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.