From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] fix dr register typo (was: typo in target-i386/ops_sse.h)
Date: Fri, 28 Nov 2008 00:37:32 +0100 [thread overview]
Message-ID: <492F2F3C.3090005@web.de> (raw)
In-Reply-To: <492F2984.9050806@web.de>
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
Jan Kiszka wrote:
> ...
> That reminds me that we should have a "zero new warnings policy" for
> changes. But reality still looks different...
...and I'm the first one to shoot (I should really start building also
upstream qemu with gcc4):
--------->
Fix register name typo in dumping debug registers.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
target-i386/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 037540d..f2d91df 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -647,7 +647,7 @@ void cpu_dump_state(CPUState *env, FILE *f,
for(i = 0; i < 4; i++)
cpu_fprintf(f, "DR%d=%016" PRIx64 " ", i, env->dr[i]);
cpu_fprintf(f, "\nDR6=%016" PRIx64 " DR7=%016" PRIx64 "\n",
- env->dr[6], env->cr[7]);
+ env->dr[6], env->dr[7]);
} else
#endif
{
@@ -681,7 +681,7 @@ void cpu_dump_state(CPUState *env, FILE *f,
(uint32_t)env->cr[4]);
for(i = 0; i < 4; i++)
cpu_fprintf(f, "DR%d=%08x ", i, env->dr[i]);
- cpu_fprintf(f, "\nDR6=%08x DR7=%08x\n", env->dr[6], env->cr[7]);
+ cpu_fprintf(f, "\nDR6=%08x DR7=%08x\n", env->dr[6], env->dr[7]);
}
if (flags & X86_DUMP_CCOP) {
if ((unsigned)env->cc_op < CC_OP_NB)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2008-11-27 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 21:30 [Qemu-devel] typo in target-i386/ops_sse.h Frank Mehnert
2008-11-27 22:49 ` andrzej zaborowski
2008-11-27 23:13 ` [Qemu-devel] " Jan Kiszka
2008-11-27 23:37 ` Jan Kiszka [this message]
2008-12-02 19:40 ` [Qemu-devel] [PATCH] fix dr register typo Anthony Liguori
2008-11-28 0:05 ` [Qemu-devel] Re: typo in target-i386/ops_sse.h andrzej zaborowski
2008-11-28 8:23 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492F2F3C.3090005@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.