From: James Pearson <james-p@moving-picture.com>
To: alsa-devel@alsa-project.org
Subject: Help with Creative's X-Fi drivers
Date: Fri, 28 Nov 2008 17:17:58 +0000 [thread overview]
Message-ID: <493027C6.3090905@moving-picture.com> (raw)
I know the ALSA team don't support Creative's X-Fi drivers, but maybe
someone could help with this issue:
I've managed to 'backport' Creative's recently GPL'd drivers to run on a
CentOS4 kernel with ALSA 1.0.15 - the changes to the code were minor,
but one thing I'm not sure about is, in ctpcm.c it has:
static int ct_pcm_timer_stop(struct ct_atc_pcm *apcm)
{
unsigned long flags;
CTDPF("%s is called\n", __func__);
spin_lock_irqsave(&apcm->timer_lock, flags);
apcm->stop_timer = 1;
del_timer(&apcm->timer);
spin_unlock_irqrestore(&apcm->timer_lock, flags);
try_to_del_timer_sync(&apcm->timer);
return 0;
}
The CentOS4/RHEL4 2.6.9 kernel doesn't have try_to_del_timer_sync() -
so, should I replace it with del_timer() or del_timer_sync() ?
I'm currently using del_timer_sync() - and the driver works (I get sound
out the head phone jack) - is this OK?
Thanks
James Pearson
next reply other threads:[~2008-11-28 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 17:17 James Pearson [this message]
2008-11-28 17:39 ` Help with Creative's X-Fi drivers The Source
2008-11-29 8:43 ` William Pitcock
2008-12-01 11:31 ` James Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493027C6.3090905@moving-picture.com \
--to=james-p@moving-picture.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.