Re: [PATCH 06/12] kvm: qemu: device-assignment: cleanup irq assignment error messages

[John Rousseau <jrrousseau@gmail.com>]

Mark McLoughlin wrote:
> Replace perror() usage with sane error message.
> 
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> ---
>  qemu/hw/device-assignment.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
> index 2b2ef68..b39617a 100644
> --- a/qemu/hw/device-assignment.c
> +++ b/qemu/hw/device-assignment.c
> @@ -473,9 +473,10 @@ void assigned_dev_update_irq(PCIDevice *d)
>              assigned_irq_data.host_irq = assigned_dev->real_device.irq;
>              r = kvm_assign_irq(kvm_context, &assigned_irq_data);
>              if (r < 0) {
> -                perror("assigned_dev_update_irq");
> -                fprintf(stderr, "Are you assigning a device "
> -                        "that shares IRQ with some other device?\n");
> +                fprintf(stderr, "Failed to assign irq for \"%s\": %s\n",
> +                        adev->name, strerror(-r));
> +                fprintf(stderr, "Perhaps you re you assigning a device "

Typo.

> +                        "that shares IRQ with another device?\n");
>                  pci_unregister_device(&assigned_dev->dev);
>                  /* FIXME: Delete node from list */
>                  continue;

-John