All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>
Cc: MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: [PATCH mptcp-next v6 0/5] BPF path manager, part 6
Date: Wed, 16 Apr 2025 11:42:00 +0200	[thread overview]
Message-ID: <4930938c-7ed2-48bb-aa93-0f94c34c1084@kernel.org> (raw)
In-Reply-To: <a51db524559756f66f544cfad08f2448b45d5080.camel@kernel.org>

Hi Geliang,

On 16/04/2025 09:29, Geliang Tang wrote:
> Hi Matt,
> 
> On Tue, 2025-04-15 at 11:16 +0800, Geliang Tang wrote:
>> Hi Matt,
>>
>> On Tue, 2025-04-08 at 20:13 +0200, Matthieu Baerts wrote:
>>> Hi Geliang,
>>>
>>> On 28/03/2025 05:01, Geliang Tang wrote:
>>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>>
>>>> v6:
>>>>  - squash accept_new_subflow patches into one.
>>>>  - change "pm->subflows == subflows_max - 1" to
>>>> 	pm->subflows + 1 == subflows_max.
>>>>  - not to call accept_new_subflow under the PM lock.
>>>>  - add mptcp_pm_accept_subflow helpers.
>>>>  - drop READ_ONCE in mptcp_pm_worker.
>>>>  - clear all the pm status flags once in mptcp_pm_worker.
>>>
>>> Thank you for the new version.
>>>
>>> FYI, I'm still thinking about how to handle PM lock should be
>>> handled. I
>>> will come back to you later. I might suggest a new version with
>>> some
>>> modifications if that's OK, that might be easier.
>>
>> Thanks for helping me think about this part around the PM lock. Look
>> forward to your feedback.
> 
> If you have time to take over this part around the PM lock, that would
> be even better and I would be very grateful.

Sure, no problem, I will have a look. But sadly, for the moment, it is
hard for me to dedicate a long time on some tasks. It might take a bit
of time for me to look at it, but I think that's fine, we are not in a rush.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      reply	other threads:[~2025-04-16  9:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28  4:01 [PATCH mptcp-next v6 0/5] BPF path manager, part 6 Geliang Tang
2025-03-28  4:01 ` [PATCH mptcp-next v6 1/5] mptcp: pm: call pm worker handler without pm lock Geliang Tang
2025-05-06  3:21   ` Geliang Tang
2025-03-28  4:01 ` [PATCH mptcp-next v6 2/5] mptcp: pm: add accept_new_subflow() interface Geliang Tang
2025-03-28  4:01 ` [PATCH mptcp-next v6 3/5] mptcp: pm: add established() interface Geliang Tang
2025-03-28  4:01 ` [PATCH mptcp-next v6 4/5] mptcp: pm: add subflow_established() interface Geliang Tang
2025-03-28  4:01 ` [PATCH mptcp-next v6 5/5] mptcp: pm: drop is_userspace in subflow_check_next Geliang Tang
2025-03-28  5:09 ` [PATCH mptcp-next v6 0/5] BPF path manager, part 6 MPTCP CI
2025-04-08 18:13 ` Matthieu Baerts
2025-04-15  3:16   ` Geliang Tang
2025-04-16  7:29     ` Geliang Tang
2025-04-16  9:42       ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4930938c-7ed2-48bb-aa93-0f94c34c1084@kernel.org \
    --to=matttbe@kernel.org \
    --cc=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.