From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1L6LBF-0004Ew-Kh for mharc-grub-devel@gnu.org; Sat, 29 Nov 2008 03:27:57 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6LBD-0004Eq-1n for grub-devel@gnu.org; Sat, 29 Nov 2008 03:27:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6LBB-0004Ee-LB for grub-devel@gnu.org; Sat, 29 Nov 2008 03:27:54 -0500 Received: from [199.232.76.173] (port=44983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6LBB-0004Eb-Ez for grub-devel@gnu.org; Sat, 29 Nov 2008 03:27:53 -0500 Received: from mx2.wp.pl ([212.77.101.6]:9509 helo=mx1.wp.pl) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L6LBB-0007Cd-3E for grub-devel@gnu.org; Sat, 29 Nov 2008 03:27:53 -0500 Received: (wp-smtpd smtp.wp.pl 5152 invoked from network); 29 Nov 2008 09:27:44 +0100 Received: from 87-205-160-178.adsl.inetia.pl (HELO [192.168.1.2]) (deadwood@[87.205.160.178]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with AES256-SHA encrypted SMTP for ; 29 Nov 2008 09:27:44 +0100 Message-ID: <4930FD07.4000107@wp.pl> Date: Sat, 29 Nov 2008 09:27:51 +0100 From: Krzysztof Smiechowicz User-Agent: Thunderbird 2.0.0.18 (X11/20081125) MIME-Version: 1.0 To: The development of GRUB 2 References: <492863A7.7090902@wp.pl> <20081128201408.GG7980@thorin> In-Reply-To: <20081128201408.GG7980@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000005 [gcc2] X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (1203?) Subject: Re: [PATCH] Corrections to affs and sfs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Nov 2008 08:27:55 -0000 Hello, Robert Millan pisze: >> Index: fs/sfs.c >> =================================================================== >> --- fs/sfs.c (revision 1919) >> +++ fs/sfs.c (working copy) >> @@ -172,7 +172,8 @@ >> return grub_errno; >> } >> >> - for (i = 0; i < grub_be_to_cpu16 (tree->nodes); i++) >> + grub_uint16_t nodescount = grub_be_to_cpu16(tree->nodes); >> + for (i = nodescount - 1; i >= 0; i--) > > nodescount is only used once; why adding a variable? No particular reason. Feel free to correct it :) Best regards, Krzysztof