From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: x86 emulator: switch 'pop reg' instruction to emulate_pop()
Date: Sat, 29 Nov 2008 20:35:32 +0200
Message-ID: <49318B74.7060209@redhat.com>
References: <20081127194353.5E440A006D@cleopatra.tlv.redhat.com> <20081128094747.432594c4@frecb000711>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:59190 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751393AbYK2Sfz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 29 Nov 2008 13:35:55 -0500
In-Reply-To: <20081128094747.432594c4@frecb000711>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Guillaume Thouvenin wrote:
> With this patch kvmctl ./user/test/x86/realmode.flat failed if
> emulate_invalid_guest_state is enabled. The error is:
>
> emulation failed (emulation failure) rip 99 66 2d 9a 01
>
> It seems that instruction pointer is wrong.
>
>   

Yes, 'call' was using the pop_instruction path.  I fixed it up.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.