From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Haxby Subject: Re: [PATCH 0 of 2] Fix keymap handling for vnc console Date: Mon, 01 Dec 2008 14:42:40 +0000 Message-ID: <4933F7E0.2040309@oracle.com> References: <491DB5E8.2050509@oracle.com> <4922E5B6.5010308@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4922E5B6.5010308@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Pat Campbell Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Pat Campbell wrote: > Are the keymap files and vnc_keysym.h changes independent of the code > changes? Not sure what others think but if they are independent then > there should be two distinct patch sets. One for keysmaps and > vnc_keysym.h and another for the keysym/scancode handling. > > Yes, the changes are reasonably independent although one shouldn't use the updated keymaps without the corresponding keymap/scancode handling because duplicate keysyms cause problems with the current code. > Although not as inclusive, I see some vnc_keysym.h changes have been > recently sent upstream to qemu-devel. Are you going to send a derivative > of this patch set upstream to qemu-devel? > [Qemu-devel] AltGr and dead keys with VNC > Those keysyms are indeed present in my patch; the iso-level3-switch change is already part of the xen code. > (vnc_keysym.h patch) > [Qemu-devel] Wrong keyboard mapping for Belgian keyboard (bug report) > > That's a familiar looking bug report. The problem described there is the problem with duplicate keysyms in the keymap which the original code completely failed to address. I'll try to assemble a similar patch to this one and send it up to qemu-devel. > I would be interested in your two programs. > > I'll post those shortly as well. jch