From: roel kluin <roel.kluin@gmail.com>
To: davidsen@tmr.com
Cc: tytso@mit.edu, adilger@sun.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] ext3, ext4: do_split() fix loop, with obvious unsigned wrap
Date: Mon, 01 Dec 2008 14:28:25 -0500 [thread overview]
Message-ID: <49343AD9.4020606@gmail.com> (raw)
Fix loop, with obvious unsigned wrap
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
index 3e5edc9..b0dcfb3 100644
--- a/fs/ext3/namei.c
+++ b/fs/ext3/namei.c
@@ -1188,7 +1188,7 @@ static struct ext3_dir_entry_2 *do_split(handle_t *handle, struct inode *dir,
/* Split the existing block in the middle, size-wise */
size = 0;
move = 0;
- for (i = count-1; i >= 0; i--) {
+ for (i = count; i--; ) {
/* is more than half of this entry in 2nd half of the block? */
if (size + map[i].size/2 > blocksize/2)
break;
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 63adcb7..34232c6 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1198,7 +1198,7 @@ static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir,
/* Split the existing block in the middle, size-wise */
size = 0;
move = 0;
- for (i = count-1; i >= 0; i--) {
+ for (i = count; i--; ) {
/* is more than half of this entry in 2nd half of the block? */
if (size + map[i].size/2 > blocksize/2)
break;
next reply other threads:[~2008-12-01 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 19:28 roel kluin [this message]
2008-12-02 13:24 ` [PATCH v2] ext3, ext4: do_split() fix loop, with obvious unsigned wrap Theodore Tso
2008-12-02 17:08 ` Bill Davidsen
2008-12-02 19:47 ` Roel Kluin
2008-12-02 21:57 ` Theodore Tso
2008-12-02 23:17 ` Bill Davidsen
2008-12-03 14:25 ` Bill Davidsen
2008-12-03 6:05 ` Andrew Morton
2008-12-03 14:32 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49343AD9.4020606@gmail.com \
--to=roel.kluin@gmail.com \
--cc=adilger@sun.com \
--cc=davidsen@tmr.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.