From: Boaz Harrosh <bharrosh@panasas.com>
To: michaelc@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org
Subject: Re: iscsi update for 2.6.29
Date: Tue, 02 Dec 2008 19:10:49 +0200 [thread overview]
Message-ID: <49356C19.3020207@panasas.com> (raw)
In-Reply-To: <1228199536-12595-1-git-send-email-michaelc@cs.wisc.edu>
michaelc@cs.wisc.edu wrote:
> This patchset is for 2.6.29. This should be the final patches
> to prepare the iscsi layer for cxgb3i, which looks like it
> has gone through the netdev review and will be sent here next
> shortly.
>
> This patchset was made over scsi-misc, and the fix here.
> http://marc.info/?l=linux-scsi&m=122815519326207&w=2
> (the fix in that email does not conflict with this patchset
> and can be applied over or before these patches).
>
> cxgb3i adds a new offload model. Where qla4xxx offloaded pretty
> much everything, and bnx2i offloaded the iscsi sequence processing
> (give it the iscsi scsi command pdu and the offload engine will
> handle everything between), cxgb3i offloads operations like
> digest, padding, and data transfers. It relies on the iscsi layer
> for the sequence state machine, so this patchset is basically
> just breaking up iscsi_tcp into a lib layer so cxgb3i can share
> the code.
>
OK I tested that lot finally, and it's good. I'm able to bang
bidi commands on it and it seems to works. exofs (was osdfs) mounts
and works as before. I'll let it run through the night and see if
it holds. (It should)
So the generic layer of this patchset is tested.
I have sent comments about bidi mistakes made in the cxgb3i side
of this patchset but never got a response and it seems they have not
been fixed. But I might have missed the fixes. is the cxgb3i branch on
git://git.kernel.org/pub/scm/linux/kernel/git/mnc/linux-2.6-iscsi.git
the latest iteration of these patches? I'll have another look if you want?
If you want I can help you set up a SW only OSD setup, to test if cxgb3i
is bidi clean. What about the other accel cards?
One more test that I never did is OSD (bidi) commands with header+data
digest enabled. Now with OSC's OSD target over TOMO's stgt I should be
able to test that. IBM's target did not support it because OSD has its
own digest stuff. TOMO's stgt does supports header+data digest right?
I should run these tests later this week. Just to make sure the digest
stuff is bidi safe. I'm sure it is but just that I never tested it.
Thanks
Boaz
next prev parent reply other threads:[~2008-12-02 17:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 6:32 iscsi update for 2.6.29 michaelc
2008-12-02 6:32 ` [PATCH 01/13] prepare iscsi_tcp helpers for LLDs that can offload some operations michaelc
2008-12-02 6:32 ` [PATCH 02/13] libiscsi: prepare libiscsi for new offload engines by modifying unsol data code michaelc
2008-12-02 6:32 ` [PATCH 03/13] iser: convert iser to new alloc_pdu api michaelc
2008-12-02 6:32 ` [PATCH 04/13] iscsi_tcp: convert to new alloc_hdr api michaelc
2008-12-02 6:32 ` [PATCH 05/13] iscsi_tcp: remove unused r2t handling michaelc
2008-12-02 6:32 ` [PATCH 06/13] libiscsi: change login data buffer allocation michaelc
2008-12-02 6:32 ` [PATCH 07/13] iscsi_tcp: add iscsi_tcp prefix to iscsi_tcp functions michaelc
2008-12-02 6:32 ` [PATCH 08/13] iscsi_tcp: split module into lib and lld michaelc
2008-12-02 6:32 ` [PATCH 09/13] iscsi_tcp: hook iscsi_tcp into new libiscsi_tcp module michaelc
2008-12-02 6:32 ` [PATCH 10/13] libiscsi: allow drivers to modify the itt sent to the target michaelc
2008-12-02 6:32 ` [PATCH 11/13] libiscsi: pass opcode into alloc_pdu callout michaelc
2008-12-02 6:32 ` [PATCH 12/13] libiscsi: handle init task failures michaelc
2008-12-02 6:32 ` [PATCH 13/13] libiscsi_tcp: support padding offload michaelc
2008-12-02 17:10 ` Boaz Harrosh [this message]
2008-12-02 17:52 ` iscsi update for 2.6.29 Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49356C19.3020207@panasas.com \
--to=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.