From: Eric Sandeen <sandeen@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: roel kluin <roel.kluin@gmail.com>,
sct@redhat.com, adilger@sun.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext3: also fix loop in do_split()
Date: Tue, 02 Dec 2008 14:29:35 -0600 [thread overview]
Message-ID: <49359AAF.6010803@redhat.com> (raw)
In-Reply-To: <20081202120751.8b0226ca.akpm@linux-foundation.org>
Andrew Morton wrote:
> A local variable called `i' should always have signed type. In fact,
> it should have `int' type. Doing
>
> unsigned i;
>
> is an act of insane vandalism, punishable by spending five additional
> years coding in fortran.
>
> I suggest you fix this by giving `i' the type God intended, or by
> making it unsigned and then renaming it to something which is not
> intended to trick programmers and reviewers.
>
> Sheesh.
/me hangs head in shame, and points feebly but only halfheartedly at the
other people who reviewed the change when it originally went in... I
have no idea what I was thinking. Sorry. Please don't make me go back
to Fortran.
-Eric
next prev parent reply other threads:[~2008-12-02 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 9:40 [PATCH] ext3: also fix loop in do_split() roel kluin
2008-12-02 20:07 ` Andrew Morton
2008-12-02 20:29 ` Eric Sandeen [this message]
2008-12-02 21:01 ` [PATCH v4] ext3, ext4: make i signed " Roel Kluin
2008-12-05 16:32 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49359AAF.6010803@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.