From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re: [PATCH 2/2] linux/x86: use shared page indicating the need for an EOI notification) Date: Wed, 03 Dec 2008 07:58:56 +0000 Message-ID: <49364A50.76E4.0078.0@novell.com> References: <492FCF0D.76E4.0078.0@novell.com> <20081203020720.GA15798%yamahata@valinux.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20081203020720.GA15798%yamahata@valinux.co.jp> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Isaku Yamahata Cc: xen-devel@lists.xensource.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org >>> Isaku Yamahata 03.12.08 03:07 >>> >Hi Jan. Thank you for taking care of not breaking existing code. >However there is an ia64 specific issue in this patch. >Here is the patch to fix it. I'm sorry for that, I really tried to not break ia64. >And I have an issue: >MFN is passed from a guest to the VMM to indicate a page in guest. >However I think GMFN should be used, instead of MFN like >grant table, xenoprof and other hypercalls. >I'll post two patches to rename the related stuff. Hmm, I know too little about ia64 Xen to understand the significance of that difference. >evtchn, physdev: fix pirq_eoi_mfn for IA64 support. > >On ia64, global variables aren't in identity mapping area (i.e. kaddr) >so that there is no relationship between its virtual address and >its physical address. Thus virt_to_bus() can't be applied to them. >So introduce arbitrary_virt_to_bus() to wrap arch dependent function >and make use of it. The same applies to x86-64, but virt_to_bus() (or rather the underlying virt_to_phys()) is prepared to deal with that situation. So it rather = sounds like a shortcoming of the ia64 variant to me... Jan