From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/1] Char: n_tty, include module.h
Date: Wed, 03 Dec 2008 16:35:26 +0100 [thread overview]
Message-ID: <4936A73E.7060508@gmail.com> (raw)
In-Reply-To: <20081203153351.1a1c054c@lxorguk.ukuu.org.uk>
Alan Cox napsal(a):
> On Wed, 03 Dec 2008 16:17:52 +0100
> Jiri Slaby <jirislaby@gmail.com> wrote:
>
>> On 12/03/2008 01:43 PM, Alan Cox wrote:
>>> On Wed, 3 Dec 2008 13:28:58 +0100
>>> Jiri Slaby <jirislaby@gmail.com> wrote:
>>>
>>>> Since we are using EXPORT_SYMBOL, we should include linux/module.h
>>>>
>>>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>>> NAK
>>>
>>> n_tty doesn't use EXPORT_SYMBOL.
>> Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a
>> ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix
>
> And that patch isn't going in either. Ask Andrew to drop it instead. If
> the rest of the PPS stuff goes in then I'll redo that part of the n_tty
> stuff differently and cleanly.
Fair enough. Andrew, could you?
prev parent reply other threads:[~2008-12-03 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 12:28 [PATCH 1/1] Char: n_tty, include module.h Jiri Slaby
2008-12-03 12:43 ` Alan Cox
2008-12-03 15:17 ` Jiri Slaby
2008-12-03 15:33 ` Alan Cox
2008-12-03 15:35 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4936A73E.7060508@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.