All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] PATCH: hwmon-fschmd-watchdog-v4.patch
Date: Wed, 03 Dec 2008 16:04:06 +0000	[thread overview]
Message-ID: <4936ADF6.7020007@redhat.com> (raw)
In-Reply-To: <493007E2.4070101@redhat.com>



Jean Delvare wrote:
> Hi Hans,
> 
> On Wed, 03 Dec 2008 13:19:36 +0100, Hans de Goede wrote:
>> Jean Delvare wrote:
>>> Hi Hans,
>>>
>>> On Fri, 28 Nov 2008 16:01:54 +0100, Hans de Goede wrote:
>>>> Hi Jean,
>>>>
>>>> Today I had access to my FSC test machine for the first time in a while. So 
>>>> here is the latest version of my watchdog support for Siemens hwmon IC's patch. 
>>>> This fixes the last 2 issues you spotted during review. Can you please queue 
>>>> this for 2.6.29 ? If Wim comes up with anything during his review I'll fix that 
>>>> with a follow up patch,
>>> Applied, thanks. Now I'm waiting for the patch which deprecates fscher
>>> and fscpos :)
>>>
>> Attached (to be applied on top of the previous 2 fschmd patches).
> 
> Looks good, with minor issues (which I fixed myself):
> 
>> Now that the new merged fschmd driver has gained support for the watchdog
>> integrated into these IC's, there is no more reason to keep the old fscher and
>> fscpos drivers around, so mark them as depcrated.
> 
> Typo: deprecated.
> 
>> -	  This is a new merged driver for FSC sensor chips which is intended
>> -	  as a replacement for the fscpos, fscscy and fscher drivers and adds
>> -	  support for several other FCS sensor chips.
>> +	  This is a merged driver for FSC sensor chips replacing the fscpos,
>> +	  fscscy and fscher drivers and adding support for several other FCS
>> +	  sensor chips.
> 
> You certainly mean FSC not FCS.

Err, yes that type was actually carried over from the old text, but this is a 
good moment to fix it :)

> 
> Additionally, I think it would be a good idea to have an entry for this
> in Documentation/feature-removal-schedule.txt, so that it doesn't get
> overlooked. I suggest to schedule the removal in 6 months from now, so
> June 2009. OK?
> 

OK

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2008-12-03 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-28 15:01 [lm-sensors] PATCH: hwmon-fschmd-watchdog-v4.patch Hans de Goede
2008-11-28 16:17 ` Jean Delvare
2008-12-03 12:19 ` Hans de Goede
2008-12-03 15:37 ` Jean Delvare
2008-12-03 16:04 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4936ADF6.7020007@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.