From mboxrd@z Thu Jan 1 00:00:00 1970 From: NISHIGUCHI Naoki Subject: Re: [RFC][PATCH] scheduler: credit scheduler for client virtualization Date: Thu, 04 Dec 2008 16:45:15 +0900 Message-ID: <49378A8B.6080904@jp.fujitsu.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , xen-devel@lists.xensource.com Cc: Ian.Pratt@eu.citrix.com, disheng.su@intel.com List-Id: xen-devel@lists.xenproject.org Thank you for your comment. I'll try to be suitable for both server and client. Regards, Naoki Nishiguchi Keir Fraser wrote: > On 03/12/2008 08:54, "NISHIGUCHI Naoki" wrote: > >> Please review this patch. >> Any comments are appreciated. > > Don't hack it into the existing sched_credit.c unless you are really sharing > significant amounts of stuff (which it looks like you aren't?). > sched_bcredit.c would be a cleaner name if there's no sharing. Is a new > scheduler necessary -- could the existing credit scheduler be generalised > with your boost mechanism to be suitable for both client and server? > > The issue with multiple schedulers is that it's most likely the non-default > will not be tested, used or maintained. The default credit scheduler gets > little enough love as it is, and it's really the only sensible scheduler to > choose now (SEDF is not great -- good example of a rotten non-default > scheduler). > > -- Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel