From: Adrian-Ken Rueegsegger <ken@codelabs.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, steffen.klassert@secunet.com
Subject: Re: [PATCH 4/4][RFC] crypto: michael_mic - Switch to shash
Date: Thu, 04 Dec 2008 09:04:38 +0100 [thread overview]
Message-ID: <49378F16.9040705@codelabs.ch> (raw)
In-Reply-To: <20081204032956.GA16987@gondor.apana.org.au>
Herbert Xu wrote:
> On Thu, Dec 04, 2008 at 01:18:12AM +0100, Adrian-Ken Rueegsegger wrote:
>> struct michael_mic_ctx {
>> + u32 l, r;
>> +};
>> +
>> +struct michael_mic_desc_ctx {
>> u8 pending[4];
>> size_t pending_len;
>>
>> u32 l, r;
>> };
>
> Any reason why you left them in the desc context?
As I explained in the other mail, the values l and r are not readonly.
Therefor I believe they need to be copied from the tfm context to the
descriptor upon transformation.
Adrian
next prev parent reply other threads:[~2008-12-04 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 0:18 [PATCH 0/4] Switch remaining algorithms to shash Adrian-Ken Rueegsegger
2008-12-04 0:18 ` [PATCH 1/4] crypto: sha512 - Remove W (message schedule) from struct sha512_ctx Adrian-Ken Rueegsegger
2008-12-04 0:18 ` [PATCH 2/4] crypto: sha512 - Switch to shash Adrian-Ken Rueegsegger
2008-12-04 0:18 ` [PATCH 3/4] crypto: wp512 " Adrian-Ken Rueegsegger
2008-12-04 0:18 ` [PATCH 4/4][RFC] crypto: michael_mic " Adrian-Ken Rueegsegger
2008-12-04 3:29 ` Herbert Xu
2008-12-04 8:04 ` Adrian-Ken Rueegsegger [this message]
2008-12-04 6:48 ` [PATCH 0/4] Switch remaining algorithms " Herbert Xu
2008-12-04 7:55 ` Adrian-Ken Rueegsegger
2008-12-04 8:02 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49378F16.9040705@codelabs.ch \
--to=ken@codelabs.ch \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.