All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Mark McLoughlin <markmc@redhat.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] Use guards in virtio-net for easier upstream merging
Date: Thu, 04 Dec 2008 09:09:10 -0600	[thread overview]
Message-ID: <4937F296.3060902@codemonkey.ws> (raw)
In-Reply-To: <1228392408.3732.72.camel@blaa>

Mark McLoughlin wrote:
> On Wed, 2008-12-03 at 14:32 -0600, Anthony Liguori wrote:
>
>   
>> @@ -189,6 +205,9 @@ static void virtio_net_receive(void *opaque, const uint8_t *buf, int size)
>>      struct virtio_net_hdr_mrg_rxbuf *mhdr = NULL;
>>      int hdr_len, offset, i;
>>  
>> +    if (!virtio_net_can_receive(opaque))
>> +        return;
>>     
>
> Should pass the buffer size to virtio_net_can_receive() to limit the
> work virtqueue_avail_bytes() has to do.
>   

Sure, I have to resubmit anyway because I left tap_vnet disable (didn't 
refresh before sending patch-doh!).

Regards,

Anthony Liguori

> Cheers,
> Mark.
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   


      reply	other threads:[~2008-12-04 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03 20:32 [PATCH] Use guards in virtio-net for easier upstream merging Anthony Liguori
2008-12-04 12:06 ` Mark McLoughlin
2008-12-04 15:09   ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4937F296.3060902@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.