All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: lachlan@sgi.com
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Remove unused variable in ktrace_free()
Date: Thu, 04 Dec 2008 09:29:35 -0600	[thread overview]
Message-ID: <4937F75F.8070302@sandeen.net> (raw)
In-Reply-To: <4937765D.2030601@sgi.com>

Lachlan McIlroy wrote:
> entries_size is probably left over from when we used to pass the
> size to kmem_free().

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

> --- xfs-fix.orig/fs/xfs/support/ktrace.c
> +++ xfs-fix/fs/xfs/support/ktrace.c
> @@ -113,21 +113,16 @@ ktrace_alloc(int nentries, unsigned int
>   void
>   ktrace_free(ktrace_t *ktp)
>   {
> -	int     entries_size;
> -
>   	if (ktp == (ktrace_t *)NULL)
>   		return;
> 
>   	/*
>   	 * Special treatment for the Vnode trace buffer.
>   	 */
> -	if (ktp->kt_nentries == ktrace_zentries) {
> +	if (ktp->kt_nentries == ktrace_zentries)
>   		kmem_zone_free(ktrace_ent_zone, ktp->kt_entries);
> -	} else {
> -		entries_size = (int)(ktp->kt_nentries * sizeof(ktrace_entry_t));
> -
> +	else
>   		kmem_free(ktp->kt_entries);
> -	}
> 
>   	kmem_zone_free(ktrace_hdr_zone, ktp);
>   }
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2008-12-04 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  6:19 [PATCH] Remove unused variable in ktrace_free() Lachlan McIlroy
2008-12-04  7:09 ` Christoph Hellwig
2008-12-04 15:29 ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4937F75F.8070302@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=lachlan@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.