All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Shane McDonald <mcdonald.shane@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	bzolnier@gmail.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Resurrect IT8172 IDE controller driver
Date: Thu, 04 Dec 2008 19:10:16 +0300	[thread overview]
Message-ID: <493800E8.7070901@ru.mvista.com> (raw)
In-Reply-To: <b2b2f2320812031908se18efdft1a94cb2b158f540e@mail.gmail.com>

Hello.

Shane McDonald wrote:

>>Alan Cox wrote:

>>>>> It's 240, not 242 ns as 33 is actually 33.333.

>>>> The maximum values give cycle time of 480 ns menaing that the controller
>>>>doesn't support PIO mode 0. Hm...

>>>Even if you clear the enable for the timing register ?

>>  These fast timing bits are documented as reserved.

> The spec says that PIO mode 0 is supported, but Sergei is correct --
> the maximum values give a cycle time of 480 ns.  How can this be?  The
> old driver appeared to have tried to support PIO mode 0 by setting to
> the maximum.

>   Which fast timing bits are documented as reserved?  My spec has the
> IDE Drive 0/1 Recovery Time and IDE Drive 0/1 Pulse Width bits in it.
> Are there other timing bits that aren't documented in my spec?

    Off the top of my head: bits 0, 3, 4, and 7 at offset 0x40 are not 
reserved in PIIX/ICH -- they enable the programmable timings for PIO and/or 
DMA. If they were left cleared, 600 ns cycle (PIO mode 0) was used.

>   Please excuse my dumb question -- I'm a little over my head here.

>>>Alan

> Shane

MBR, Sergei

  reply	other threads:[~2008-12-04 16:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24  6:21 [PATCH] Resurrect IT8172 IDE controller driver Shane McDonald
2008-11-24  9:55 ` Alan Cox
2008-11-24 10:02   ` Sergei Shtylyov
2008-11-24 10:33 ` Sergei Shtylyov
2008-11-24 12:12   ` Sergei Shtylyov
2008-11-24 12:32     ` Alan Cox
2008-11-24 13:38       ` Sergei Shtylyov
2008-12-04  3:08         ` Shane McDonald
2008-12-04 16:10           ` Sergei Shtylyov [this message]
2008-12-04  2:39   ` Shane McDonald
2008-12-04 10:07     ` Alan Cox
2008-12-04 14:01       ` Shane McDonald
2008-12-04 14:07         ` Alan Cox
2008-12-04 19:37           ` Bartlomiej Zolnierkiewicz
2008-12-04 16:17       ` Sergei Shtylyov
2008-12-08 12:02     ` Sergei Shtylyov
2008-12-22  7:50       ` Shane McDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493800E8.7070901@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcdonald.shane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.