[U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

[Ben Warren <biggerbadderben@gmail.com>]

stefan.althoefer at web.de wrote:
> [PATCH] common: nvedit to protect additional ethernet addresses
>
> This patch adds "ethaddr1" and "ethaddr2" to the protected
> environment variables that can only be written once.
>
> ----
> The patch is against "latest" u-boot git-repository
>
> Please be patient if style of submission or patches are
> offending.
>
> Signed-off-by: stefan.althoefer at web.de  (as at janz.de)
>   
This needs to be above a '---' line.  Also, this format is wrong.  It 
should have a real name and one e-mail address.  I recommend using 'git 
format-patch' for generating patches.
> ----
>
> diff -uprN u-boot-orig//common/cmd_nvedit.c u-boot/common/cmd_nvedit.c
> --- u-boot-orig//common/cmd_nvedit.c	2008-12-02 17:25:31.000000000 +0100
> +++ u-boot/common/cmd_nvedit.c	2008-12-02 22:59:36.000000000 +0100
> @@ -188,6 +188,8 @@ int _do_setenv (int flag, int argc, char
>  #else
>  		    (strcmp (name, "serial#") == 0) ||
>  #endif
> +		    (strcmp (name, "ethaddr1") == 0) ||
> +		    (strcmp (name, "ethaddr2") == 0) ||
>  		    ((strcmp (name, "ethaddr") == 0)
>   
How about this as a more scalable solution: (note that some boards have 
up to "ethaddr5")

       (strstr(name, "ethaddr") == name)
>  #if defined(CONFIG_OVERWRITE_ETHADDR_ONCE) && defined(CONFIG_ETHADDR)
>  		     && (strcmp ((char *)env_get_addr(oldval),MK_STR(CONFIG_ETHADDR)) != 0)
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>   
regards,
Ben