All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@cfl.rr.com>
To: heinzm@redhat.com, device-mapper development <dm-devel@redhat.com>
Subject: Re: dm targets with spaces in the name
Date: Thu, 4 Dec 2008 15:15:51 -0500	[thread overview]
Message-ID: <49383A77.80903@cfl.rr.com> (raw)
In-Reply-To: <1228405956.23557.74.camel@o>

Heinz Mauelshagen wrote:
> What you describe here, is essentially caused by bogus names in vendor
> metadata not being detected and handled properly by dmraid.
> 
> Which metadata format is that being caused by ?

isw

> Can you send me the metadata sample retrieved via "dmraid -rD"
> (bzip2/tar the resulting *.{dat,offset,size} files before sending) ?

See https://bugs.launchpad.net/ubuntu/+source/dmraid/+bug/299311

and

http://launchpadlibrarian.net/19744950/dmraid%20dump.tar.gz

Basically the user named his volume "Mother Brain 2" when he created it 
in the bios, so dmraid tries to create the target "isw_cfebfidbf_Mother 
Brain 2" which works, but then it can't use that device as the target 
for the partition linear mapping "isw_cfebfidbf_Mother Brain 21" ( that 
would be "2p1" but for some reason debian/ubuntu have a patch that 
removes the p ).

>> So should you just avoid doing this,
> 
> Yes, whitespace is not to be supported in mapped device names.

Why not?  File names with spaces in them are valid, even for dev nodes. 
  I can use dmsetup to create a device with a space in the name.  It 
seems like it should then be valid to use that device as a target in 
another one.

>> or should the kernel be fixed to 
>> understand quotes or backslash escapes or something to allow spaces in 
>> the target device file name?
> 
> No M$ worries, please ;)

Not sure what you mean there, but I actually took a look at the kernel 
code, and it was failing to parse the correct number of arguments, but 
it looks like dm_split_args() DOES understand backslash escaping.  When 
I backslash escape the spaces in the name, it appears to parse the 
correct number of arguments, yet linear_ctr() still fails with "Device 
lookup failure".

  reply	other threads:[~2008-12-04 20:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03 17:03 dm targets with spaces in the name Phillip Susi
2008-12-04 15:52 ` Heinz Mauelshagen
2008-12-04 20:15   ` Phillip Susi [this message]
2008-12-05  1:59     ` Alasdair G Kergon
2008-12-05 16:58       ` Phillip Susi
2008-12-05 17:08         ` Alasdair G Kergon
2008-12-08 20:31           ` Phillip Susi
2008-12-15 14:09             ` Heinz Mauelshagen
2008-12-15 16:18               ` Phillip Susi
2008-12-16  8:55                 ` Heinz Mauelshagen
2008-12-09 13:58   ` Arvin Schnell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49383A77.80903@cfl.rr.com \
    --to=psusi@cfl.rr.com \
    --cc=dm-devel@redhat.com \
    --cc=heinzm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.