From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Allow passing of --directory to git-am.
Date: Thu, 04 Dec 2008 23:26:16 +0100 [thread overview]
Message-ID: <49385908.5020202@fs.ei.tum.de> (raw)
In-Reply-To: <7vhc5jeo60.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Simon 'corecode' Schubert <corecode@fs.ei.tum.de> writes:
>
>> We need to play some shell tricks to be able to pass directory names
>> which contain spaces and/or quotes.
>
> There already was an earlier attempt for this feature by Kevin Ballard,
> which had issues I pointed out:
>
> http://thread.gmane.org/gmane.comp.version-control.git/94335/focus=94456
>
> The patch was carried for a few weeks in 'pu' but was dropped due to lack
> of follow-up updates.
>
> Does your version address the issues Kevin's one had?
You mean not storing/restoring the flags across an invocation? No, that's
a different thing. My patch only adds the --directory option, it does not
fix the previously existing bug.
cheers
simon
--
<3 the future +++ RENT this banner advert +++ ASCII Ribbon /"\
rock the past +++ space for low €€€ NOW!1 +++ Campaign \ /
Party Enjoy Relax | http://dragonflybsd.org Against HTML \
Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \
next prev parent reply other threads:[~2008-12-04 22:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 18:48 [PATCH] Allow passing of --directory to git-am Simon 'corecode' Schubert
2008-12-04 18:51 ` Jeff King
2008-12-04 19:27 ` Junio C Hamano
2008-12-04 22:26 ` Simon 'corecode' Schubert [this message]
2008-12-04 22:33 ` Junio C Hamano
2008-12-04 23:14 ` Junio C Hamano
2008-12-04 23:36 ` [PATCH - DONTUSE] git-am: propagate -C/-p as well Junio C Hamano
2008-12-04 23:41 ` [PATCH] Allow passing of --directory to git-am Simon 'corecode' Schubert
2008-12-05 0:11 ` Junio C Hamano
2008-12-05 0:16 ` Simon 'corecode' Schubert
2008-12-04 19:35 ` Jakub Narebski
2008-12-04 22:25 ` Simon 'corecode' Schubert
2008-12-04 22:46 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2008-12-04 17:04 Simon 'corecode' Schubert
2008-12-04 18:28 ` Boyd Stephen Smith Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49385908.5020202@fs.ei.tum.de \
--to=corecode@fs.ei.tum.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.