All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lachlan McIlroy <lachlan@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Use the incore inode size in xfs_file_readdir()
Date: Fri, 05 Dec 2008 14:22:55 +1100	[thread overview]
Message-ID: <49389E8F.5000301@sgi.com> (raw)
In-Reply-To: <20081204070827.GB29531@infradead.org>

Christoph Hellwig wrote:
> On Thu, Dec 04, 2008 at 05:59:08PM +1100, Lachlan McIlroy wrote:
>> We should be using the incore inode size here not the linux inode
>> size.  The incore inode size is always up to date for directories
>> whereas the linux inode size is not updated for directories.
>>
>> We've hit assertions in xfs_bmap() and traced it back to the linux
>> inode size being zero here but the incore size being correct.
> 
> Heh. Looks good, but you can still call ->readdir with a 0 inode size,
> so you might want to check for that (actualyl I think other pathes
> are goign to take care of it, but..)

What if we remove bufsize and pass PAGE_SIZE into xfs_readdir()?
No need to worry about a 0 inode size.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2008-12-05  3:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  6:59 [PATCH] Use the incore inode size in xfs_file_readdir() Lachlan McIlroy
2008-12-04  7:08 ` Christoph Hellwig
2008-12-05  3:22   ` Lachlan McIlroy [this message]
2008-12-17 14:20     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49389E8F.5000301@sgi.com \
    --to=lachlan@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.