From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id mB53Rcko029414 for ; Thu, 4 Dec 2008 21:27:39 -0600 Received: from sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 32CA61665BEE for ; Thu, 4 Dec 2008 19:27:37 -0800 (PST) Received: from sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id ZiZoO8D8UvK28pvR for ; Thu, 04 Dec 2008 19:27:37 -0800 (PST) Message-ID: <49389F81.1090306@sandeen.net> Date: Thu, 04 Dec 2008 21:26:57 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: Device loses barrier support References: <20081204100050.GN6703@one.firstfloor.org> <20081204142015.GQ6703@one.firstfloor.org> <20081204145810.GR6703@one.firstfloor.org> <20081204174838.GS6703@one.firstfloor.org> In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mikulas Patocka Cc: Andi Kleen , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Andi Kleen , Alasdair G Kergon , Milan Broz Mikulas Patocka wrote: > Another thing: > > I'm wondering, where in fsync() does Linux wait for hardware disk cache to > be flushed? Isn't there a bug that fsync() will return before the cache is > flushed? I couldn't really find it. The last thing do_fsync calls is > filemap_fdatawait and it doesn't do cache flush (blkdev_issue_flush). ext4, reiserfs, and xfs all call blkdev_issue_flush() in their ->fsync file operations (or down that path). -Eric _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757236AbYLED10 (ORCPT ); Thu, 4 Dec 2008 22:27:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753877AbYLED07 (ORCPT ); Thu, 4 Dec 2008 22:26:59 -0500 Received: from sandeen.net ([209.173.210.139]:13373 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756502AbYLED07 (ORCPT ); Thu, 4 Dec 2008 22:26:59 -0500 Message-ID: <49389F81.1090306@sandeen.net> Date: Thu, 04 Dec 2008 21:26:57 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105) MIME-Version: 1.0 To: Mikulas Patocka CC: Andi Kleen , Milan Broz , Andi Kleen , linux-kernel@vger.kernel.org, Alasdair G Kergon , xfs@oss.sgi.com Subject: Re: Device loses barrier support References: <20081204100050.GN6703@one.firstfloor.org> <20081204142015.GQ6703@one.firstfloor.org> <20081204145810.GR6703@one.firstfloor.org> <20081204174838.GS6703@one.firstfloor.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mikulas Patocka wrote: > Another thing: > > I'm wondering, where in fsync() does Linux wait for hardware disk cache to > be flushed? Isn't there a bug that fsync() will return before the cache is > flushed? I couldn't really find it. The last thing do_fsync calls is > filemap_fdatawait and it doesn't do cache flush (blkdev_issue_flush). ext4, reiserfs, and xfs all call blkdev_issue_flush() in their ->fsync file operations (or down that path). -Eric