All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lachlan McIlroy <lachlan@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Remove XFS_BUF_SHUT() and friends
Date: Fri, 05 Dec 2008 14:52:47 +1100	[thread overview]
Message-ID: <4938A58F.6090109@sgi.com> (raw)
In-Reply-To: <20081204132746.GA27400@infradead.org>

Christoph Hellwig wrote:
> On Thu, Dec 04, 2008 at 06:27:16PM +1100, Lachlan McIlroy wrote:
>> Code does nothing so remove it.
> 
> Looks good to me.  Does anyone remember why this flag was set on IRIX?

During a forced shutdown we would go through all incore buffers and mark
them B_STALE/B_ERROR/B_SHUT and then call biodone() on them.  The code in
xfs_buf_iodone_callbacks() that checks for B_SHUT is to avoid a double
biodone() I think.  We don't have the code in the Linux port that scans
through all the incore buffers on a forced shutdown but we still have one
case in xfs_iflush_cluster().  In any case it's not doing anything.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2008-12-05  3:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  7:27 [PATCH] Remove XFS_BUF_SHUT() and friends Lachlan McIlroy
2008-12-04 13:27 ` Christoph Hellwig
2008-12-05  3:52   ` Lachlan McIlroy [this message]
2008-12-17 14:20     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4938A58F.6090109@sgi.com \
    --to=lachlan@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.