All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: tsec: Fix Marvell 88E1121R phy init
Date: Thu, 04 Dec 2008 23:09:53 -0800	[thread overview]
Message-ID: <4938D3C1.6030201@gmail.com> (raw)
In-Reply-To: <2acbd3e40812021346u304f2807k4d28b00197cf554a@mail.gmail.com>

Hi Anatolij & Andy,

Andy Fleming wrote:
> On Tue, Dec 2, 2008 at 3:31 AM, Anatolij Gustschin <agust@denx.de> wrote:
>   
>> This patch tries to ensure that phy interrupt pin
>> won't be asserted after booting. We experienced
>> following issues with current 88E1121R phy init:
>>
>> Marvell 88E1121R phy can be hardware-configured
>> to share MDC/MDIO and interrupt pins for both ports
>> P0 and P1 (e.g. as configured on socrates board).
>> Port 0 interrupt pin will be shared by both ports
>> in such configuration. After booting Linux and
>> configuring eth0 interface, port 0 phy interrupts
>> are enabled. After rebooting without proper eth0
>> interface shutdown port 0 phy interrupts remain
>> enabled so any change on port 0 (link status, etc.)
>> cause assertion of the interrupt. Now booting Linux
>> and configuring eth1 interface will cause permanent
>> phy interrupt storm as the registered phy 1 interrupt
>> handler doesn't acknowledge phy 0 interrupts. This
>> of course should be fixed in Linux driver too.
>>     
>
> Agreed, and...
>
>   
>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>>     
>
> Acked-by: Andy Fleming <afleming@freescale.com>
>   
Applied to net repo.

thanks,
Ben

      reply	other threads:[~2008-12-05  7:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02  9:31 [U-Boot] [PATCH] net: tsec: Fix Marvell 88E1121R phy init Anatolij Gustschin
2008-12-02 21:46 ` Andy Fleming
2008-12-05  7:09   ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4938D3C1.6030201@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.