From: NISHIGUCHI Naoki <nisiguti@jp.fujitsu.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: Ian.Pratt@eu.citrix.com, disheng.su@intel.com, keir.fraser@eu.citrix.com
Subject: [RFC][PATCH 3/4] sched: balance credits of each vcpu of a domain
Date: Fri, 05 Dec 2008 19:07:00 +0900 [thread overview]
Message-ID: <4938FD44.3000409@jp.fujitsu.com> (raw)
In-Reply-To: <4938FC06.9080008@jp.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 128 bytes --]
By applying this patch, the credit scheduler balances credits of each
active vcpu of a domain.
Best regards,
Naoki Nishiguchi
[-- Attachment #2: credit_balance.patch --]
[-- Type: text/x-patch, Size: 1565 bytes --]
diff -r a00eb6595d3c xen/common/sched_credit.c
--- a/xen/common/sched_credit.c Sat Nov 29 09:07:52 2008 +0000
+++ b/xen/common/sched_credit.c Fri Dec 05 18:16:34 2008 +0900
@@ -835,7 +835,8 @@ csched_acct(void)
int credit_balance;
int credit_xtra;
int credit;
-
+ int64_t credit_sum;
+ int credit_average;
spin_lock_irqsave(&csched_priv.lock, flags);
@@ -872,6 +873,18 @@ csched_acct(void)
BUG_ON( sdom->active_vcpu_count == 0 );
BUG_ON( sdom->weight == 0 );
BUG_ON( sdom->weight > weight_left );
+
+ /* Compute the average of active VCPUs. */
+ credit_sum = 0;
+ list_for_each_safe( iter_vcpu, next_vcpu, &sdom->active_vcpu )
+ {
+ svc = list_entry(iter_vcpu, struct csched_vcpu, active_vcpu_elem);
+ BUG_ON( sdom != svc->sdom );
+
+ credit_sum += atomic_read(&svc->credit);
+ }
+ credit_average = ( credit_sum + (sdom->active_vcpu_count - 1)
+ ) / sdom->active_vcpu_count;
weight_left -= sdom->weight;
@@ -944,8 +957,9 @@ csched_acct(void)
svc = list_entry(iter_vcpu, struct csched_vcpu, active_vcpu_elem);
BUG_ON( sdom != svc->sdom );
- /* Increment credit */
- atomic_add(credit_fair, &svc->credit);
+ /* Balance and increment credit */
+ credit = atomic_read(&svc->credit);
+ atomic_add(credit_average - credit + credit_fair, &svc->credit);
credit = atomic_read(&svc->credit);
/*
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2008-12-05 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 10:01 [RFC][PATCH 0/4] Modification of credit scheduler NISHIGUCHI Naoki
2008-12-05 10:05 ` [RFC][PATCH 1/4] sched: more accurate credit scheduling NISHIGUCHI Naoki
2008-12-05 10:05 ` [RFC][PATCH 2/4] sched: change the handling of credits over upper bound NISHIGUCHI Naoki
2008-12-05 10:09 ` NISHIGUCHI Naoki
2008-12-05 10:07 ` NISHIGUCHI Naoki [this message]
2008-12-08 8:53 ` [RFC][PATCH 4/4] sched: introduce boost credit for latency-sensitive domain NISHIGUCHI Naoki
-- strict thread matches above, loose matches on Subject: below --
2008-12-18 2:57 [RFC][PATCH 0/4] Modification of credit scheduler rev2 NISHIGUCHI Naoki
2008-12-18 3:04 ` [RFC][PATCH 3/4] sched: balance credits of each vcpu of a domain NISHIGUCHI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4938FD44.3000409@jp.fujitsu.com \
--to=nisiguti@jp.fujitsu.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Pratt@eu.citrix.com \
--cc=disheng.su@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.