From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phillip Susi Subject: Re: dm targets with spaces in the name Date: Fri, 5 Dec 2008 11:58:30 -0500 Message-ID: <49395DB6.6050802@cfl.rr.com> References: <4936BBC6.7000800@cfl.rr.com> <1228405956.23557.74.camel@o> <49383A77.80903@cfl.rr.com> <20081205015938.GQ26097@agk.fab.redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081205015938.GQ26097@agk.fab.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: device-mapper development List-Id: dm-devel.ids Alasdair G Kergon wrote: > I can't guarantee that names with spaces in them have had much testing > as LVM doesn't permit them. But device-mapper itself and dmsetup > are supposed to support them. > Tools really should not be passing path names into constructors - use the > major:minor format instead as the in-kernel code paths are much more > predictable, there are fewer opportunities for races and so it offers > better control to the userspace code. But if you run dmsetup and key in a table referencing a device with a space in the name, that is what happens; linear_ctr gets passed "/dev/foo bar" as the path argv. Shouldn't it then be just as capable of opening the device as a call to open()?