From: Jan Kiszka <jan.kiszka@web.de>
To: kvm-devel <kvm@vger.kernel.org>
Cc: Avi Kivity <avi@redhat.com>, Jes Sorensen <jes@sgi.com>
Subject: [PATCH] kvm-userspace: Fix -no-kvm-irqchip
Date: Fri, 05 Dec 2008 20:20:38 +0100 [thread overview]
Message-ID: <49397F06.9040001@web.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
Commit fc94d163d1e3424199166cf50449e03447400579 broke -no-kvm-irqchip.
This fixes the issue by restoring the logic of
kvm_update_interrupt_request /wrt IRQ injection from the IO thread.
[However, I did not yet get the need for all the additional tests in
that function.]
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
qemu/qemu-kvm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
index a7cfa24..9ca8da4 100644
--- a/qemu/qemu-kvm.c
+++ b/qemu/qemu-kvm.c
@@ -117,7 +117,7 @@ void kvm_update_interrupt_request(CPUState *env)
int signal = 0;
if (env) {
- if (current_env && !current_env->kvm_cpu_state.created)
+ if (!current_env || !current_env->kvm_cpu_state.created)
signal = 1;
/*
* Testing for created here is really redundant
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next reply other threads:[~2008-12-05 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 19:20 Jan Kiszka [this message]
2008-12-07 10:14 ` [PATCH] kvm-userspace: Fix -no-kvm-irqchip Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49397F06.9040001@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=jes@sgi.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.