From: James Smart <James.Smart@Emulex.Com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fc transport: pre-emptively terminate i/o upon dev_loss_tmo timeout
Date: Fri, 5 Dec 2008 17:41:26 -0500 [thread overview]
Message-ID: <4939AE16.5060506@emulex.com> (raw)
In-Reply-To: <4939AB67.5010509@cs.wisc.edu>
Agreed - thanks Mike.
-- james s
Mike Christie wrote:
> James Smart wrote:
>> diff -upNr a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
>> --- a/drivers/scsi/scsi_transport_fc.c 2008-10-18 10:32:52.000000000 -0400
>> +++ b/drivers/scsi/scsi_transport_fc.c 2008-12-05 12:13:54.000000000 -0500
>> @@ -3012,6 +3012,16 @@ fc_timeout_deleted_rport(struct work_str
>> @@ -3035,7 +3045,6 @@ fc_timeout_deleted_rport(struct work_str
>> * went away and didn't come back - we'll remove
>> * all attached scsi devices.
>> */
>> - spin_unlock_irqrestore(shost->host_lock, flags);
>>
>> scsi_target_unblock(&rport->dev);
>> fc_queue_work(shost, &rport->stgt_delete_work);
>>
>
> We do not need this unblock call anymore. The added
> fc_terminate_rport_io will do this. I attached a patch that removes it
> for you.
>
next prev parent reply other threads:[~2008-12-05 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 17:18 [PATCH] fc transport: pre-emptively terminate i/o upon dev_loss_tmo timeout James Smart
2008-12-05 22:29 ` Mike Christie
2008-12-05 22:41 ` James Smart [this message]
2008-12-08 22:31 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4939AE16.5060506@emulex.com \
--to=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.