All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Chen <wangchen@cn.fujitsu.com>
To: Greg KH <gregkh@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>, NETDEV <netdev@vger.kernel.org>
Subject: Re: [PATCH next] staging-p80211: Kill directly reference of	c
Date: Sat, 06 Dec 2008 10:28:45 +0800	[thread overview]
Message-ID: <4939E35D.4010102@cn.fujitsu.com> (raw)
In-Reply-To: <20081205154446.GB28030@suse.de>

Greg KH said the following on 2008-12-5 23:44:
> On Fri, Dec 05, 2008 at 11:14:53PM +0800, Wang Chen wrote:
>> In this driver, netdev's private data is wlandevice_t.
>> And the wlandev(type of wlandevice_t) is exist before netdev be allocated.
>> So use netdev->ml_priv to point to the private data.
>>
>> I am not sure whether I should consider the kernel version older than 2.3.38.
>> Because in those kernels, netdevice_t is "structure dev" instead of 
>> "structure net_device" and of course "dev->ml_priv" will cause compile error.
>> But before my patch, in function wlan_setup(), there is a ether_setup(net_device)
>> which already broke kernels which older than 2.3.38.
> 
> Heh, no we only need to support the current mainline kernel with this
> driver, no old 2.3.x versions :)
> 

Thanks for your explanation.

> thanks for the patch, I'll queue it up,
> 

I'm doing this "kill netdev->priv" work on Dave's net-next tree now.
So, will it be better to let Dave apply this to his net-next instead
you apply it?
Just suggestion :)


  reply	other threads:[~2008-12-06  2:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 15:14 [PATCH next] staging-p80211: Kill directly reference of netdev->priv Wang Chen
2008-12-05 15:44 ` Greg KH
2008-12-06  2:28   ` Wang Chen [this message]
2008-12-06  2:30     ` [PATCH next] staging-p80211: Kill directly reference of c David Miller
2008-12-06  2:41       ` Greg KH
2008-12-06  3:06         ` David Miller
2008-12-07  7:58 ` [PATCH next] staging-p80211: Kill directly reference of netdev->priv David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4939E35D.4010102@cn.fujitsu.com \
    --to=wangchen@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.