From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: kai@kaishome.de, linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH 1/7] pata_ninja32: update ID table
Date: Sat, 06 Dec 2008 16:34:23 +0300 [thread overview]
Message-ID: <493A7F5F.2070301@ru.mvista.com> (raw)
In-Reply-To: <20081205194231.17133.42760.stgit@localhost.localdomain>
Hello.
Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
> diff --git a/drivers/ata/pata_ninja32.c b/drivers/ata/pata_ninja32.c
> index 4e466ea..4dd9a3b 100644
> --- a/drivers/ata/pata_ninja32.c
> +++ b/drivers/ata/pata_ninja32.c
>
[...]
> @@ -130,7 +130,8 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id)
> return rc;
> pci_set_master(dev);
>
> - /* Set up the register mappings */
> + /* Set up the register mappings. We use the I/O mapping as only the
> + older chips also have MMIO on BAR 1 */
>
CodingStyle, chapter 8. It's only an examplet preferrable comment
style there though...
MBR, Sergei
next prev parent reply other threads:[~2008-12-06 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 19:42 [PATCH 1/7] pata_ninja32: update ID table Alan Cox
2008-12-05 19:42 ` [PATCH 2/7] pata_ali: force initialise a few bits Alan Cox
2008-12-05 19:43 ` [PATCH 3/7] ata: Fix experimental tags Alan Cox
2008-12-06 1:05 ` Robert Hancock
2008-12-09 5:49 ` Jeff Garzik
2008-12-05 19:43 ` [PATCH 4/7] libata: Drain data on errors Alan Cox
2008-12-05 19:43 ` [PATCH 5/7] libata: Improve timeout handling Alan Cox
2008-12-05 19:43 ` [PATCH 6/7] libata: clean up the SFF code for coding style Alan Cox
2008-12-05 20:29 ` Jeff Garzik
2008-12-05 19:44 ` [PATCH 7/7] libata: Add 32bit PIO support Alan Cox
2008-12-05 20:16 ` Elias Oltmanns
2008-12-06 0:25 ` Alan Cox
2008-12-06 13:34 ` Sergei Shtylyov [this message]
2008-12-09 5:48 ` [PATCH 1/7] pata_ninja32: update ID table Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493A7F5F.2070301@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=kai@kaishome.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.