From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christian Lamparter <chunkeey@web.de>
Cc: Greg KH <gregkh@suse.de>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
John W Linville <linville@tuxdriver.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [RFC][PATCH] p54usb: rewriting rx/tx routines to make use of usb_anchor's facilities
Date: Sat, 06 Dec 2008 15:47:26 -0600 [thread overview]
Message-ID: <493AF2EE.20605@lwfinger.net> (raw)
In-Reply-To: <200812062109.40590.chunkeey@web.de>
Christian Lamparter wrote:
>
> Alan, I've got a question about:
> "Create and initialize a usb_anchor structure, and each time you create
> a new URB, call usb_anchor_urb(). Then you can free the URB as soon as
> it is submitted; the anchor will keep it pinned until it completes, and
> it is automatically removed from the anchor when the completion routine
> is called."
>
> Do we have to call usb_free_urb again, if we're resubmitting the urb in the
> complete callback? (the code what I'm referring to is p54u_rx_cb in p54usb.c)
I am very interested in the answer to this question. My interpretation is that
you cannot resubmit the urb after it has been posted to usb_anchor_usb() because
the USB core will have deleted it, and that the callback routine will have to
allocate a new urb, anchor it, and then free it as well.
Larry
next prev parent reply other threads:[~2008-12-06 21:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 14:47 [PATCH] p54usb: fix usb_kill_urb hang with slub_debug=P Christian Lamparter
2008-12-05 15:14 ` Larry Finger
2008-12-05 15:58 ` Christian Lamparter
2008-12-05 15:53 ` Greg KH
2008-12-05 23:18 ` Larry Finger
2008-12-05 23:23 ` Greg KH
2008-12-06 20:09 ` [RFC][PATCH] p54usb: rewriting rx/tx routines to make use of usb_anchor's facilities Christian Lamparter
2008-12-06 21:47 ` Larry Finger [this message]
2008-12-07 4:15 ` Alan Stern
2008-12-08 14:06 ` [RFC][PATCH v2] " Christian Lamparter
2008-12-08 14:06 ` Christian Lamparter
2008-12-05 23:28 ` [PATCH] p54usb: fix usb_kill_urb hang with slub_debug=P Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493AF2EE.20605@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=gregkh@suse.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.