From: Avi Kivity <avi@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: kvm-devel <kvm@vger.kernel.org>,
linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 2/2] kvm: use cpumask_var_t for cpus_hardware_enabled
Date: Sun, 07 Dec 2008 17:55:50 +0200 [thread overview]
Message-ID: <493BF206.4070007@redhat.com> (raw)
In-Reply-To: <200812072125.45757.rusty@rustcorp.com.au>
Rusty Russell wrote:
> This changes cpus_hardware_enabled from a cpumask_t to a cpumask_var_t:
> equivalent for CONFIG_CPUMASKS_OFFSTACK=n, otherwise dynamically allocated.
>
>
> -static cpumask_t cpus_hardware_enabled;
> +static cpumask_var_t cpus_hardware_enabled
This isn't on stack, so it isn't buying us anything.
Is the plan to drop cpumask_t? If so, we're penalizing non-stack users
by forcing them to go through another pointer (and cacheline).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-12-07 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 10:55 [PATCH 2/2] kvm: use cpumask_var_t for cpus_hardware_enabled Rusty Russell
2008-12-07 15:55 ` Avi Kivity [this message]
2008-12-08 6:05 ` Rusty Russell
2008-12-08 9:46 ` Avi Kivity
2008-12-08 11:50 ` Rusty Russell
2008-12-08 14:29 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493BF206.4070007@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.