All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Karen Xie <kxie@chelsio.com>
Cc: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
	James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH 2/2 2.6.29] cxgb3i - accelerating open-iscsi initiator
Date: Mon, 08 Dec 2008 15:21:18 -0600	[thread overview]
Message-ID: <493D8FCE.5020500@cs.wisc.edu> (raw)
In-Reply-To: <200812082030.mB8KUOMD029251@localhost.localdomain>

Karen Xie wrote:
> [PATCH 2/2 2.6.29] cxgb3i - accelerating open-iscsi initiator
> 
> From: Karen Xie <kxie@chelsio.com> 
> 
> Add cxgb3i iSCSI driver.
> 
> This patch implements the cxgb3i iscsi connection acceleration for the
> open-iscsi initiator.
> 
> The cxgb3i driver offers the iscsi PDU based offload:
> - digest insertion and verification
> - payload direct-placement into host memory buffer.
> 
> Signed-off-by: Karen Xie <kxie@chelsio.com>

There are a couple issues with using network functions instead of 
defining your own (I guess some are not widespread because other code is 
not using it yet) and a function that is no longer used (cxgb3 net 
driver function replaced by common iscsi functionality), but they are 
small and can probably be fixed up after the merge with a simple patch 
(I can submit it after it is merged if you guys want).

The iscsi hook in parts look ok.

Acked-by: Mike Christie <michaelc@cs.wisc.edu>

  reply	other threads:[~2008-12-08 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-08 20:30 [PATCH 2/2 2.6.29] cxgb3i - accelerating open-iscsi initiator Karen Xie
2008-12-08 21:21 ` Mike Christie [this message]
2008-12-09 14:37 ` Boaz Harrosh
2008-12-09 17:10   ` Mike Christie
2008-12-09 18:42     ` Boaz Harrosh
2008-12-09 18:42   ` Karen Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493D8FCE.5020500@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=kxie@chelsio.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.