From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Mark Lord <liml@rtr.ca>,
rob.opensuse.linux@googlemail.com
Subject: Re: [PATCH #upstream-fixes 1/3] pata_hpt366: fix clock detection
Date: Tue, 09 Dec 2008 00:49:58 -0500 [thread overview]
Message-ID: <493E0706.8020900@garzik.org> (raw)
In-Reply-To: <493CED7A.2010505@kernel.org>
Tejun Heo wrote:
> pata_hpt366 had its clock detection wrong and detected 25Mhz as 40Mhz
> and vice-versa. Fix it.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/ata/pata_hpt366.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: work/drivers/ata/pata_hpt366.c
> ===================================================================
> --- work.orig/drivers/ata/pata_hpt366.c
> +++ work/drivers/ata/pata_hpt366.c
> @@ -382,10 +382,10 @@ static int hpt36x_init_one(struct pci_de
> /* PCI clocking determines the ATA timing values to use */
> /* info_hpt366 is safe against re-entry so we can scribble on it */
> switch((reg1 & 0x700) >> 8) {
> - case 5:
> + case 9:
> hpriv = &hpt366_40;
> break;
> - case 9:
> + case 5:
> hpriv = &hpt366_25;
applied #upstream-fixes
Avoiding patch #2 in this series b/c the thread seemed to indicate it
needed more work
Avoiding patch #3 in this series awaiting Alan's ack (did I miss it?)
prev parent reply other threads:[~2008-12-09 5:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 9:48 [PATCH #upstream-fixes 1/3] pata_hpt366: fix clock detection Tejun Heo
2008-12-08 9:52 ` [PATCH #upstream-fixes 2/3] pata_hpt366: fix cable detection Tejun Heo
2008-12-08 10:01 ` [PATCH #upstream-fixes 3/3] pata_hpt366: update mode programming Tejun Heo
2008-12-08 11:23 ` [PATCH #upstream-fixes 2/3] pata_hpt366: fix cable detection Sergei Shtylyov
2008-12-08 11:44 ` Alan Cox
2008-12-08 13:59 ` Sergei Shtylyov
2008-12-08 14:04 ` Sergei Shtylyov
2008-12-09 1:17 ` Tejun Heo
2008-12-09 5:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493E0706.8020900@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=rob.opensuse.linux@googlemail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.